Skip to content
Snippets Groups Projects
  1. Jun 02, 2017
  2. May 22, 2017
  3. May 18, 2017
  4. May 15, 2017
  5. May 12, 2017
    • gabrielC's avatar
      bug fixes from Fujitsu (bug 29) · 893f36e8
      gabrielC authored
      ----------------------------------------------------------
      bug 29
      
      Ttile:
      FDD should be TDD.
      
      Bug Location:
        switch (oai_emulation.info.frame_type[0]) {
        case FDD:
          frame_type = "FDD";
          break;
      
        case TDD:
          frame_type = "FDD";
          break;
        }
      ----------------------------------------------------------
      893f36e8
    • gabrielC's avatar
      bug fixes from Fujitsu (bugs 18, 19, 20) · bdaef795
      gabrielC authored
      ----------------------------------------------------------
      bug 18
      
      Ttile:
      Probably he/she wants to copy the contents of arrays, but
      this coding doesn't copy anything, moreover index overflow
      occurs.
      
      Bug Location:
      u2e_t[UE_id][eNB_id]->tx_data[3]=tx[eNB_id][3];
      u2e_t[UE_id][eNB_id]->rx_data[3]=rx[NB_eNB_INST+UE_id][3];
      
      Note:
      Detected by CppCheck
      ----------------------------------------------------------
      bug 19
      
      Title:
      Probably he/she wants to copy the contents of arrays, but
      this coding doesn't copy anything, moreover index overflow
      occurs.
      
      Bug Location:
      e2u_t[eNB_id][UE_id]->tx_data[3]=tx[NB_eNB_INST+UE_id][3];
      e2u_t[eNB_id][UE_id]->rx_data[3]=rx[eNB_id][3];
      
      Note:
      Detected by CppCheck
      ----------------------------------------------------------
      bug 20
      
      Title:
      Probably he/she wants to copy the contents of arrays, but
      this coding doesn't copy anything, moreover index overflow
      occurs.
      
      Bug Location:
      tx_data[3]=cthread->tx_data[3];
      rx_data[3]=cthread->rx_data[3];
      
      Note:
      Detected by CppCheck
      ----------------------------------------------------------
      bdaef795
  6. May 03, 2017
  7. Apr 24, 2017
  8. Apr 18, 2017
  9. Apr 10, 2017
    • Cedric Roux's avatar
      integration fix: change the way to print the version · 10113a35
      Cedric Roux authored
      Using "system" to call "git log" is too error-prone.
      In the test setup, lte-softmodem was blocked because
      "git log" uses a pager ("less") and the pager was
      waiting for the user to press enter.
      
      We could pass "--no-pager" to "git log" but then
      what if someone runs the softmodem out of the source
      tree?
      
      cmake defines PACKAGE_VERSION, we can use that instead,
      as is done in openair-cn.
      10113a35
  10. Apr 03, 2017
  11. Mar 27, 2017
  12. Mar 24, 2017
  13. Mar 23, 2017
    • Cedric Roux's avatar
      RRC Rel14 · 4fcb6272
      Cedric Roux authored
      - import RRC ASN.1 defintions from the specifications
        (file openair2/RRC/LITE/MESSAGES/asn1c/ASN1_files/RRC-e10.asn)
        contrary to rel8/10, all modules have been imported, maybe it's too much
        to refine in case of problems
      - deal with rel14 in fix_asn1
      - all code that was for Rel10 is now for Rel10/Rel14
      - some incompatible changes (mostly in naming) were resolved in favor
        of rel14, see in openair2/RRC/LITE/defs.h
      - unsure about the rlc layer, some arrays have changed (values appended),
        I only changed the definition and in tests in the code, I changed
        the index limit, maybe it's not enough
      
      Rel14 is the default compilation mode.
      4fcb6272
    • Cedric Roux's avatar
      fix issue 227 - UE IP settings disrupts realtime · cff91499
      Cedric Roux authored
      see https://gitlab.eurecom.fr/oai/openairinterface5g/issues/227
      
      When the UE connects to the eNodeB and receives its IP address from the
      network, it calls system() to set it in the linux kernel world. This call
      is not done in a realtime thread, but in the NAS, which uses its own thread,
      independent of the realtime processing.
      
      In some situations this totally disrupts realtime processing.
      
      It is difficult to know precisely why that happens, but it seems that calling
      fork(), as system() does, in a multi-threaded program is not a good idea. (So
      say several people on the internet.) It is not clear why the softmodem is
      impacted, but it seems that fork() is really what triggers the disruption.
      Several tests lead to that conclusion.
      
      To fix the problem, we create a child background process very early in main()
      (before anything else basically). Then instead of calling system(), the main
      process sends the string to the background process. The background process
      gets the string, passes it to system() and reports the success/failure back
      to the main process.
      
      This solution involves a lot of system calls, but calling system() in the
      first place is not cheap either. As long as no realtime thread uses this
      mechanism, things should be fine. Time will tell.
      cff91499
Loading