From 1d8baf26c6437a10d44414d92d9ea62b9b962a06 Mon Sep 17 00:00:00 2001 From: esantangelo <enzo020895@gmail.com> Date: Sat, 14 Nov 2020 17:17:27 -0300 Subject: [PATCH] fix --- .../Tsi1.BusinessLayer/Helpers/ErrorMessages.cs | 1 + .../Tsi1.BusinessLayer/Services/SurveyService.cs | 14 +++++++------- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/Tsi1.Api/Tsi1.BusinessLayer/Helpers/ErrorMessages.cs b/Tsi1.Api/Tsi1.BusinessLayer/Helpers/ErrorMessages.cs index f29a7cc..322b064 100644 --- a/Tsi1.Api/Tsi1.BusinessLayer/Helpers/ErrorMessages.cs +++ b/Tsi1.Api/Tsi1.BusinessLayer/Helpers/ErrorMessages.cs @@ -59,5 +59,6 @@ namespace Tsi1.BusinessLayer.Helpers public const string SurveyIsNull = "La encuesta es nula"; public const string SurveyHasNoQuestions = "La encuesta no tiene preguntas"; public const string InvalidSurvey = "La encuesta no pertenece a la facultad con id '{0}'"; + public const string SurveyResponseAlreadyExist = "El usuario '{0}' ya completo la encuesta '{1}'"; } } diff --git a/Tsi1.Api/Tsi1.BusinessLayer/Services/SurveyService.cs b/Tsi1.Api/Tsi1.BusinessLayer/Services/SurveyService.cs index bf0bf12..51beed6 100644 --- a/Tsi1.Api/Tsi1.BusinessLayer/Services/SurveyService.cs +++ b/Tsi1.Api/Tsi1.BusinessLayer/Services/SurveyService.cs @@ -154,14 +154,15 @@ namespace Tsi1.BusinessLayer.Services if (existingSurveyResponse != null) { - _mapper.Map(surveyResponse, existingSurveyResponse); - } - else - { - var newSurveyResponse = _mapper.Map<SurveyResponse>(surveyResponse); - _context.Add(newSurveyResponse); + result.HasError = true; + result.AddMessage(string.Format(ErrorMessages.SurveyResponseAlreadyExist, surveyResponse.UserId, surveyResponse.SurveyId)); + return result; } + var newSurveyResponse = _mapper.Map<SurveyResponse>(surveyResponse); + _context.Add(newSurveyResponse); + + await _context.SaveChangesAsync(); return result; @@ -172,7 +173,6 @@ namespace Tsi1.BusinessLayer.Services var result = new ServiceResult<List<SurveyResponseDetailDto>>(); var tenant = await _context.Tenants.FirstOrDefaultAsync(x => x.Id == tenantId); - var tenantAdmin = await _context.Tenants.FirstOrDefaultAsync(x => x.Name == TenantAdmin.Name); if (tenant == null) { -- GitLab