diff --git a/common/utils/T/tracer/enb.c b/common/utils/T/tracer/enb.c index 1d97b428d3e57aad8459b5eb8b6f648a16a3eb80..9cb8d12699b5f3a0c2320ea58e95f2e3665594f5 100644 --- a/common/utils/T/tracer/enb.c +++ b/common/utils/T/tracer/enb.c @@ -386,6 +386,7 @@ int main(int n, char **v) char v[T_BUFFER_MAX]; event e; e = get_event(enb_data.socket, v, database); + if (e.type == -1) abort(); handle_event(h, e); } diff --git a/common/utils/T/tracer/event.c b/common/utils/T/tracer/event.c index e626b4a7d66594dc46ca46bda6b380ab1e71928d..0917c010b3852a95a6e0fa6f56e48315c1d19b2b 100644 --- a/common/utils/T/tracer/event.c +++ b/common/utils/T/tracer/event.c @@ -22,14 +22,14 @@ event get_event(int socket, char *event_buffer, void *database) */ again: - fullread(socket, &length, 4); + if (fullread(socket, &length, 4) == -1) goto read_error; #ifdef T_SEND_TIME - fullread(socket, &t, sizeof(struct timespec)); + if (fullread(socket, &t, sizeof(struct timespec)) == -1) goto read_error; length -= sizeof(struct timespec); #endif - fullread(socket, &type, sizeof(int)); + if (fullread(socket, &type, sizeof(int)) == -1) goto read_error; length -= sizeof(int); - fullread(socket, event_buffer, length); + if (fullread(socket, event_buffer, length) == -1) goto read_error; if (type == -1) append_received_config_chunk(event_buffer, length); if (type == -2) verify_config(); @@ -41,6 +41,9 @@ again: #else return new_event(type, length, event_buffer, database); #endif + +read_error: + return (event){type: -1}; } #ifdef T_SEND_TIME diff --git a/common/utils/T/tracer/textlog.c b/common/utils/T/tracer/textlog.c index 362ff8103eaf95a4e20403c2bafcf72f2cfaf301..2118cc1bf95732ef818a9eef31329c416e3b6d48 100644 --- a/common/utils/T/tracer/textlog.c +++ b/common/utils/T/tracer/textlog.c @@ -182,6 +182,7 @@ int main(int n, char **v) char v[T_BUFFER_MAX]; event e; e = get_event(textlog_data.socket, v, database); + if (e.type == -1) abort(); handle_event(h, e); } diff --git a/common/utils/T/tracer/utils.c b/common/utils/T/tracer/utils.c index f285a71fb115ec99a74815543adab49d9cd9c28e..3ebc000c671b62799c330775e0804e9ba8279d95 100644 --- a/common/utils/T/tracer/utils.c +++ b/common/utils/T/tracer/utils.c @@ -118,7 +118,7 @@ int fullread(int fd, void *_buf, int count) int l; while (count) { l = read(fd, buf, count); - if (l <= 0) { printf("read socket problem\n"); abort(); } + if (l <= 0) return -1; count -= l; buf += l; ret += l; diff --git a/common/utils/T/tracer/utils.h b/common/utils/T/tracer/utils.h index a5b1f1b9f663754bc478fe18b74d8205f0fe6f72..e15a8d2fbad5c6e910e3ba3e21c6b0cc219a9952 100644 --- a/common/utils/T/tracer/utils.h +++ b/common/utils/T/tracer/utils.h @@ -23,6 +23,7 @@ list *list_append(list *l, void *data); /* socket_send: return 0 if okay, -1 on error */ int socket_send(int socket, void *buffer, int size); int get_connection(char *addr, int port); +/* fullread: return length read if okay (that is: 'count'), -1 on error */ int fullread(int fd, void *_buf, int count); int connect_to(char *addr, int port); diff --git a/common/utils/T/tracer/vcd.c b/common/utils/T/tracer/vcd.c index d4972d15fc3c21afa3acdc0df4d533302231a0df..2dc34aead9d77e4c8c5f2b4a5423350c7a9dcbc3 100644 --- a/common/utils/T/tracer/vcd.c +++ b/common/utils/T/tracer/vcd.c @@ -192,6 +192,7 @@ int main(int n, char **v) char v[T_BUFFER_MAX]; event e; e = get_event(vcd_data.socket, v, database); + if (e.type == -1) abort(); handle_event(h, e); }